Skip to content

Adopt TypeScript 7#4017

Merged
nstepien merged 5 commits intomainfrom
ts7
Apr 2, 2026
Merged

Adopt TypeScript 7#4017
nstepien merged 5 commits intomainfrom
ts7

Conversation

@nstepien
Copy link
Copy Markdown
Collaborator

No description provided.

@nstepien nstepien self-assigned this Mar 28, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 28, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.41%. Comparing base (dac4ffc) to head (206aecb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4017   +/-   ##
=======================================
  Coverage   97.41%   97.41%           
=======================================
  Files          37       37           
  Lines        1470     1470           
  Branches      472      472           
=======================================
  Hits         1432     1432           
  Misses         38       38           
Files with missing lines Coverage Δ
src/EditCell.tsx 88.09% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nstepien nstepien marked this pull request as ready for review March 28, 2026 00:56
@nstepien nstepien requested a review from amanmahajan7 as a code owner March 28, 2026 00:56
Copy link
Copy Markdown
Collaborator

@amanmahajan7 amanmahajan7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I am wrong but plugin-dts does not use TS compiler to generate d.ts files?

@amanmahajan7
Copy link
Copy Markdown
Collaborator

https://tsdown.dev/options/dts#with-isolateddeclarations

If isolatedDeclarations is not enabled, tsdown will fall back to using the TypeScript compiler for .d.ts generation.

Should we add isolatedDeclarations?

@nstepien
Copy link
Copy Markdown
Collaborator Author

nstepien commented Apr 2, 2026

Should we add isolatedDeclarations?

We'd have to add a lot of return types. Not impossible, but also not sure it's worth it for RDG's size.

You can try by enabling isolatedDeclarations in tsconfig.src.json and run

> npx tsc --build tsconfig.src.json

...

Found 96 errors.

And with TSGO/TS7 being much faster, the gains from using isolatedDeclarations would be smaller.

@nstepien nstepien enabled auto-merge (squash) April 2, 2026 15:28
@nstepien nstepien merged commit 7e1d385 into main Apr 2, 2026
2 checks passed
@nstepien nstepien deleted the ts7 branch April 2, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants